Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 Runtimes #1255

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Add ARM64 Runtimes #1255

merged 5 commits into from
Oct 1, 2024

Conversation

cobya
Copy link
Contributor

@cobya cobya commented Sep 30, 2024

Since .NET 5.0, ARM64 execution has been supported for the Windows ecoystem and support was later added to macOS. Component Detection has not been publishing these binaries, so add them to the CI pipeline.

See https://learn.microsoft.com/en-us/dotnet/core/rid-catalog for more info.

@cobya cobya added version:minor type:feature Feature (new functionality) labels Sep 30, 2024
@cobya cobya requested a review from a team as a code owner September 30, 2024 21:21
@cobya cobya requested a review from chsalgado September 30, 2024 21:21
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.1%. Comparing base (79ff9ed) to head (596f2db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1255   +/-   ##
=====================================
  Coverage   89.1%   89.1%           
=====================================
  Files        360     360           
  Lines      28076   28076           
  Branches    1790    1790           
=====================================
  Hits       25028   25028           
  Misses      2661    2661           
  Partials     387     387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 1, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@cobya cobya merged commit 15c96f4 into main Oct 1, 2024
24 of 25 checks passed
@cobya cobya deleted the cobya/osxarm64 branch October 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature (new functionality) version:minor
Projects
Development

Successfully merging this pull request may close these issues.

3 participants